Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Apply corrections identified by SonarQube #8457

Merged
merged 7 commits into from
May 3, 2022
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 1, 2022


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 1, 2022
@t3chguy t3chguy requested a review from a team as a code owner May 1, 2022 09:14
@github-actions github-actions bot temporarily deployed to Netlify May 1, 2022 09:20 Destroyed
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #8457 (3367812) into develop (3e31fdb) will decrease coverage by 0.06%.
The diff coverage is 32.84%.

❗ Current head 3367812 differs from pull request most recent head 0075aa8. Consider uploading reports for the commit 0075aa8 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8457      +/-   ##
===========================================
- Coverage    30.85%   30.78%   -0.07%     
===========================================
  Files          893      893              
  Lines        50793    50764      -29     
  Branches     12928    12919       -9     
===========================================
- Hits         15671    15627      -44     
- Misses       35122    35137      +15     
Impacted Files Coverage Δ
src/ContentMessages.ts 4.34% <0.00%> (+0.04%) ⬆️
src/Lifecycle.ts 1.42% <0.00%> (+<0.01%) ⬆️
src/Markdown.ts 81.75% <ø> (+0.54%) ⬆️
src/MatrixClientPeg.ts 30.33% <ø> (-0.78%) ⬇️
src/RoomInvite.tsx 0.00% <0.00%> (ø)
src/SecurityManager.ts 3.17% <0.00%> (ø)
...ews/dialogs/security/CreateSecretStorageDialog.tsx 0.00% <0.00%> (ø)
src/autocomplete/Autocompleter.ts 11.76% <0.00%> (ø)
src/boundThreepids.ts 0.00% <0.00%> (ø)
src/components/structures/RoomDirectory.tsx 0.94% <ø> (ø)
... and 70 more

@github-actions github-actions bot temporarily deployed to Netlify May 1, 2022 10:32 Destroyed
@github-actions github-actions bot temporarily deployed to Netlify May 1, 2022 11:08 Destroyed
@t3chguy
Copy link
Member Author

t3chguy commented May 1, 2022

Sonar unhappy due to lack of coverage being hooked up

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm - thanks!

src/RoomInvite.tsx Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live May 2, 2022 08:57
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.8% 2.8% Duplication

@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 09:07 Destroyed
@github-actions github-actions bot temporarily deployed to Netlify May 3, 2022 10:33 Destroyed
@t3chguy t3chguy merged commit 964c60d into develop May 3, 2022
@t3chguy t3chguy deleted the t3chguy/sonar-fixes branch May 3, 2022 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants